Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preference to select light/dark mode #221

Open
1 task done
gruponewage opened this issue Apr 30, 2024 · 8 comments
Open
1 task done

Add preference to select light/dark mode #221

gruponewage opened this issue Apr 30, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@gruponewage
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

Please add a preference to switch from dark to light mode light/dark mode

Describe the solution you'd like

Please add a preference to switch from dark to light mode light/dark mode

Describe alternatives you've considered

No response

Additional context

No response

@gruponewage gruponewage added the enhancement New feature or request label Apr 30, 2024
@nokyan
Copy link
Owner

nokyan commented May 1, 2024

Hi,
this is similar to #188. Handling dark and light theme should be done by your desktop environment and I'd prefer not implementing a seperate toggle for Resources.

@gruponewage
Copy link
Author

Thanks! I just checked #188

@nevaforget
Copy link

any chance that the app respects gtk theming? it looks like a gtk app tho :-D
would be nice to use the set gtk theme and color-scheme 'prefer-dark'

using the arch pkg, no weird flatpak thingy

@nokyan
Copy link
Owner

nokyan commented Jul 11, 2024

any chance that the app respects gtk theming? it looks like a gtk app tho :-D would be nice to use the set gtk theme and color-scheme 'prefer-dark'

Sorry, but I'm not planning to implement anything related to theming for Resources. GTK theming (by using the GTK_THEME environment variable) was only ever supposed to be a debug feature for development and changing this variable will probably make Resources look broken. Resources should respect your dark theme setting, maybe check your DE's appearance settings.
You could look into Gradience (currently unmaintained) for some experimental libadwaita theming, though I personally can and will not guarantee that it'll work perfectly.

using the arch pkg, no weird flatpak thingy

While that's of course your choice, I'd like to point out that I don't maintain the AUR package and that Flatpak is the only supported method of installing and using Resources. I don't have the time and resources (no pun intended) to take care of weird distro quirks.

@nevaforget

This comment was marked as abuse.

@nokyan
Copy link
Owner

nokyan commented Jul 12, 2024

it's 2024, why is it so hard for anyone to implement a dark mode. shouldn't be that hard for gtk apps with prefer-dark. time to uninstall

Resources does have a dark mode, I'm using it as we speak and you can see it in action in the README's screenshots. Check your DE's settings.

Also, don't expect maintainers, who mostly use their free time to work on projects like this for no compensation, to implement suggestions with that attitude of yours.

@nevaforget

This comment was marked as abuse.

@nokyan
Copy link
Owner

nokyan commented Jul 12, 2024

I guess DEs have their own monitors wtf, why should anybody use yours there :-D haha

I don't see how one relates to the other, I made Resources specifically with the purpose of being a new and modern system monitor for GNOME, hence the use of GTK 4 and libadwaita.

furthermore, there is no screenshot in the readme, nor a mention about darkmode. here is a link to the readme, if you don't know it: https://github.com/nokyan/resources/blob/main/README.md

There's a bold "Click me for screenshots!" link right at the top revealing screenshots alternating between light and dark mode.

please stop replying

Not gonna let you tell me what to reply to in my own repo. Blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants