Android: should throw meaningful errors when the 1MB CursorWindow limit is reached

[nolanlawson]

Currently these errors just get swallowed, e.g.: pouchdb/pouchdb#5413

We just return empty results which causes bugs later on down the line that are hard to diagnose:

cordova-plugin-sqlite-2/src/android/SQLitePlugin.java

Lines 93 to 96 in 33afdef

	} catch (Throwable e) {
	if (DEBUG_MODE) {
	e.printStackTrace();
	}

[nolanlawson]

Hm interestingly this doesn't seem to actually throw an error we can catch; it just returns empty rows. Although it does log:

12-18 12:49:43.189 21171 21346 W CursorWindow: Window is full: requested allocation 2236848 bytes, free space 2096672 bytes, window size 2097152 bytes
12-18 12:49:43.205 21171 21346 W CursorWindow: Window is full: requested allocation 2236848 bytes, free space 2096672 bytes, window size 2097152 bytes

[nolanlawson]

Hm from googling around I really don't see any way to actually detect this error in code. 😕

[knubie]

Related issue at andpor/react-native-sqlite-storage#364