Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Fix Windows Compatibility #220

Closed
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed

[PR] Fix Windows Compatibility #220

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels
archive

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020 •
edited
Loading

A pull request by damc-dev at 2019-11-06 01:44:29+00:00
Original URL: zalando-incubator/kopf#220
Merged by nolar at 2019-11-12 10:30:08+00:00

When running kopf on Windows it fails due to NotImplementedError thrown by add_signal_handler method in asyncio

Issue : #219

Description

In the asyncio docs it appears that the add_signal_handler method is only available in Unix which is why it throws a NotImplementedError when kopf is run on Windows.
This PR should fix Windows compatibility by catching NotImplementedError thrown by asyncio and continuing.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

Commented by nolar at 2019-11-13 18:25:01+00:00
 

Released as kopf==0.23rc1.

damc-dev Thank you for you contribution! 😉
@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Fix Windows Compatibility Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
archive
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants