Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Refactor the synchronisation primitives #256

Closed
1 task
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed
1 task

[PR] Refactor the synchronisation primitives #256

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2019-11-25 12:29:27+00:00
Original URL: zalando-incubator/kopf#256
Merged by nolar at 2019-12-12 13:31:58+00:00

Issue : #255

Description

The existing coroutines to handle the existing synchronisation primitives (a generalised flag) are moved to the dedicated module, and tests are added (previously it was considered an implementation details and not tested directly).

A new synchronisation primitive is added to simplify the code and reduce the semantical complexity of the logic by removing the technical low-level details from it:

A toggle, which is like an event, but is bi-directional: can be turned on/off, and can be awaited until turned on/off — unlike the events, which can be awaited only until turned on, but not off.

Types of Changes

  • Refactoring

Review

List of tasks the reviewer must do to review the PR

  • Tests
@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Refactor the synchronisation primitives Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

0 participants