Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Test for finalizers #90

Closed
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed

[PR] Test for finalizers #90

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels
archive automation CI/CD: testing, linting, releasing automatically

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2019-06-01 13:13:23+00:00
Original URL: zalando-incubator/kopf#90
Merged by nolar at 2019-06-07 12:29:14+00:00

Issue : #13

Add tests for the finalizers: appending, removing, checking.

Also change the finalizer to a FQDN string — as once I hit the issue that the finalizer cannot be an arbitrary string (e.g. when assigning it to a pod in Minikube; but it works with custom resources though).

But keep the legacy finalizer (just a string, not FQDN) if it is assigned to the existing resource — for checking and for removing.

@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot mentioned this issue Aug 19, 2020
19 tasks
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Test for finalizers Aug 19, 2020
@kopf-archiver kopf-archiver bot added the automation CI/CD: testing, linting, releasing automatically label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive automation CI/CD: testing, linting, releasing automatically
Projects
None yet
Development

No branches or pull requests

0 participants