Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildinfo id exposed #953

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

wighawag
Copy link
Contributor

This expose the id of the buildInfo so plugin can identify same buildinfo and benefit from the space optimization hardhat do by sharing same buildinfo across file

@alcuadrado
Copy link
Member

@wighawag have you thought about what would happen when reading a build info that doesn't have the id? I think this change can be a bit dangerous. You are probably the only one consuming this though, so the risk is not too big to stop it.

@wighawag
Copy link
Contributor Author

I intend to use this for caching purpose.
for undefined id, I can simply do not use cache for these.

But as users move to higher version of hardhat, this won't be a problem. I could even add a warning to let user know to upgrade.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants