Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix telemetry consent prompt #956

Merged
merged 3 commits into from
Oct 26, 2020
Merged

Fix telemetry consent prompt #956

merged 3 commits into from
Oct 26, 2020

Conversation

alcuadrado
Copy link
Member

This PR implements three changes to the telemetry consent prompt:

  1. It doesn't show it if not running in an interactive terminal. When running hardhat from a script, it defaults to not reporting anything.
  2. It adds a timeout to the prompt. If we don't get an answer in a short period of time, we don't report anything, nor store any consent value.
  3. Don't enable the error reporting unless we have explicit consent from the user.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants