Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add message to expect utilities #231

Merged
merged 3 commits into from
Nov 7, 2023
Merged

feat: add message to expect utilities #231

merged 3 commits into from
Nov 7, 2023

Conversation

mortimr
Copy link
Contributor

@mortimr mortimr commented Nov 7, 2023

  • also fixes the not.toBeAContract condition
  • add test cases for toBeAContract

@mortimr
feat: add message to expect utilities
21d592f 
- also fixes the not.toBeAContract condition
- add test cases for toBeAContract
@mortimr
Copy link
Contributor Author

mortimr commented Nov 7, 2023

lmk if there's anything I need to update (examples, docs etc) and I'll update

gnkz
gnkz reviewed Nov 7, 2023
View reviewed changes
test/modules/Expect.t.sol Outdated Show resolved Hide resolved
gnkz
gnkz approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@gnkz gnkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gnkz gnkz merged commit 7e0754a into nomoixyz:main Nov 7, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
Merged
@gnkz gnkz mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnkz gnkz gnkz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mortimr @gnkz