Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nordigen\NordigenPHP\Exceptions\InstitutionExceptions\RateLimitError #14

Open
VeinFoist opened this issue Mar 1, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@VeinFoist
Copy link

Describe the bug
Reaching the bank API rate limits doesn't throw Exceptions\InstitutionExceptions\RateLimitError (but Exceptions\NordigenExceptions\NordigenException)

To Reproduce
Steps to reproduce the behavior:
Reach the rate limit on ->account()->getAccountDetails()
Received a NordigenException exception.

Expected behavior
Expected a RateLimitError exception.

Additional context
Sample code

try {
	$NordigenClient->account($account_id)->getAccountDetails();
	}
catch (Exception $e) {
	echo get_class($e);
	}

Output

Nordigen\NordigenPHP\Exceptions\NordigenExceptions\NordigenException

As far as I can tell, it should be Nordigen\NordigenPHP\Exceptions\InstitutionExceptions\RateLimitError

@VeinFoist VeinFoist added the bug Something isn't working label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant