Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Viewer Index nodes #4568

Closed
Durman opened this issue Jul 14, 2022 · 6 comments · Fixed by #4569
Closed

Multiple Viewer Index nodes #4568

Durman opened this issue Jul 14, 2022 · 6 comments · Fixed by #4569
Labels

Comments

@Durman
Copy link
Collaborator

Durman commented Jul 14, 2022

Problem statement

It seems multiple nodes does not work correctly with multiple objects.

image
untitled2.zip

@zeffii
Copy link
Collaborator

zeffii commented Jul 14, 2022

the matrix is only applied to the first object in the second idxviewer.

image

@zeffii
Copy link
Collaborator

zeffii commented Jul 14, 2022

i am reluctant to call it a bug, because i intentionally coded it this way. I'll agree that maybe it is unexpected/inconsistent behaviour

# ensure they are Matrix() multiplied
for obj_index, verts in enumerate(input_stream):
if obj_index < len(geom.matrix):
matrix = geom.matrix[obj_index]
input_stream[obj_index] = [matrix @ v for v in verts]

@Durman
Copy link
Collaborator Author

Durman commented Jul 14, 2022

I see. Then it is vectorization problem (similar to this #3908). What was the intention to code it in this way?

I think we have convention of auto matching objects number inside nodes.

@zeffii
Copy link
Collaborator

zeffii commented Jul 14, 2022

What was the intention to code it in this way?

whatever the reason was, I think it makes sense to change the behaviour to conform to current vectorization practices - i am happy to change it.

@zeffii
Copy link
Collaborator

zeffii commented Jul 14, 2022

same can be done for edges/faces -but- i like a debug tool to be as minimal as possible, inventing data is not minimal. The primary use case is for single object input, constructing geometry from scratch.

@zeffii
Copy link
Collaborator

zeffii commented Jul 14, 2022

it's tempting to revise the node further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants