Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase/decrease logging level on notary-signer #791

Closed
HuKeping opened this issue Jun 17, 2016 · 1 comment
Closed

Increase/decrease logging level on notary-signer #791

HuKeping opened this issue Jun 17, 2016 · 1 comment

Comments

@HuKeping
Copy link
Contributor

HuKeping commented Jun 17, 2016

For people who would like to try some contribute to Notary :)

For now we have already supported increasing/decreasing logging level on notary server side #748 , and it would be nice to have that functionality also on notary signer side.

Tips:
What you need to do would like to be:

  • Embed a setupSignalTrap() into the notary-signer booting process.
  • Add a handler to deal with those captured signals.
  • Add some test for your handler
  • Add some docs about it

The infra you might want to use for this feature are:

  • NotarySupportedSignals in const.go
  • AdjustLogLevel() to increase/decrease logging in utils/configuration.go
@cyli
Copy link
Contributor

cyli commented Oct 5, 2016

Fixed by #970

@cyli cyli closed this as completed Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants