Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Android X #76

Closed
garwedgess opened this issue Nov 4, 2018 · 3 comments
Closed

Add support for Android X #76

garwedgess opened this issue Nov 4, 2018 · 3 comments
Milestone

Comments

@garwedgess
Copy link

No description provided.

@noties
Copy link
Owner

noties commented Nov 5, 2018

Hello @garwedgess !

This feature will be implemented at some point for sure, just not now. Migration to android-x is far from complete in a lot of applications. Plus, there is a tool that lets a project use old compat libraries (from here):

android.useAndroidX=true
android.enableJetifier=true

and there is none the other way (android-x -> compat). Markwon (main artifact) only uses support-annotations, so there should be no problems with migration tool that Google provided

@garwedgess
Copy link
Author

Hi @noties

No problem, I'm not in a rush for it at the moment as I switched back to compat. I did try converting using Android Studios "migrate" option but it couldn't convert the annotations and therefore wouldn't build.

Good to know that you will implement support in the near future. Many thanks for the great library.

@noties noties added this to the 4.0.0 milestone Jun 4, 2019
@noties
Copy link
Owner

noties commented Jul 2, 2019

Implemented in 4.0.0 version

@noties noties closed this as completed Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants