Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fsevent crash (mutating array in iteration) #132

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

cmyr
Copy link
Contributor

@cmyr cmyr commented Nov 20, 2017

This is a quick fix for #131, although I think some questions remain around how we should be considering duplicate watch events, in general.

@passcod
Copy link
Member

passcod commented Nov 21, 2017

Looks sensible to me.

The tests failing macOS in CI are existing failures, so merging.

@passcod passcod merged commit b5672b5 into notify-rs:master Nov 21, 2017
@cmyr cmyr deleted the fix/131 branch November 21, 2017 02:09
@cmyr
Copy link
Contributor Author

cmyr commented Nov 21, 2017

@passcod great, thanks for the quick merge. Also just wanted to say your tests have been really useful to me today in trying to figure out how to write some tests of my own. Thanks! 😄 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants