Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how watch does not follow moves or renames #166

Closed
wants to merge 1 commit into from

Conversation

devurandom
Copy link

This summarises the knowledge gathered from #165 (comment)

Closes: #165

@passcod
Copy link
Member

passcod commented Sep 30, 2018

Well, yes, but this is only correct for Linux and macOS.

  • Polling doesn't follow (it can't), but will pick up later if something is moved onto the path it's watching (it doesn't know it's not the original).
  • On Windows, the platform API gets given a handle to a directory, not a path. It's somewhat unclear if that handle remains the same after a move, but I would guess it does.

@passcod passcod closed this in 414c8c8 Oct 5, 2018
baszalmstra added a commit to baszalmstra/mun that referenced this pull request Nov 19, 2019
The notify crate does not properly handle watching of recreated files on
all platform. This commit instead watches the parent directory as
proposed in the documentation of Notify.

See: notify-rs/notify#166
baszalmstra added a commit to baszalmstra/mun that referenced this pull request Nov 19, 2019
The notify crate does not properly handle watching of recreated files on
all platform. This commit instead watches the parent directory as
proposed in the documentation of Notify.

See: notify-rs/notify#166
baszalmstra added a commit to baszalmstra/mun that referenced this pull request Nov 20, 2019
The notify crate does not properly handle watching of recreated files on
all platform. This commit instead watches the parent directory as
proposed in the documentation of Notify.

See: notify-rs/notify#166
baszalmstra added a commit to mun-lang/mun that referenced this pull request Nov 22, 2019
The notify crate does not properly handle watching of recreated files on
all platform. This commit instead watches the parent directory as
proposed in the documentation of Notify.

See: notify-rs/notify#166
Mohsen7s pushed a commit to Mohsen7s/arti that referenced this pull request Feb 7, 2022
Fixes these messages:

  warning: this URL is not a hyperlink
   --> crates/arti/src/watch_cfg.rs:115:5
    |
115 | /// notify-rs/notify#165 and
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `<https://github.com/notify-rs/notify/issues/165>`
    |
    = note: `#[warn(rustdoc::bare_urls)]` on by default
    = note: bare URLs are not automatically turned into clickable links

warning: this URL is not a hyperlink
   --> crates/arti/src/watch_cfg.rs:116:5
    |
116 | /// notify-rs/notify#166 .
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `<https://github.com/notify-rs/notify/pull/166>`
    |
    = note: bare URLs are not automatically turned into clickable links
0x6e added a commit to 0x6e/slint that referenced this pull request Apr 18, 2024
Some editors may backup a file by renaming it to append ~, then saving
the new file contents to a new file. notify-rs/notify#166 explains
that a non-recursive watcher on the parent directory is the
recommended way to deal with this situation.

Closes: slint-ui#3641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants