-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the public API #65
Conversation
One other thing - I used the contents of the README for the main crate documentation. The README contents are a good starting point for this crate, and now they are now available when a user views docs locally. It might be nice to setup hosted documentation with automatic updates via travis. Then, the README can be truncated and point to the hosted docs. |
Any feedback on this? Sorry for the bump, but it's been over a week :). Thanks! |
Oh no! I'm terribly sorry, I'd misplaced this. I'll have a look asap. I really appreciate the work and discussion you've been doing :) (I've been in bed with the flu the last few days, which hasn't helped any.) |
Can we enable a compile flag to warn on missing docs? |
Thanks for looking at this, @passcod!
|
If that's true, it wouldn't be possible to except certain things by doing something like |
@@ -53,10 +63,14 @@ struct StreamContextInfo { | |||
|
|||
impl FsEventWatcher { | |||
#[inline] | |||
#[doc(hidden)] | |||
// TODO should not be pub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these should not be pub, can we unpub them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opted not to unpub them since it could theoretically be a breaking change.
`#![deny(missing_docs)]` is now specified at the crate root which requires public APIs to be documentated.
|
Can you document (at least sparsely) the windows variants? Otherwise we break the build |
Finally getting to merge this after very busy weeks at work! I'll try to set up hosted docs somewhere... |
Thanks for merging this! Somehow I missed your comment from 23 days ago...
Any action required there? |
I set missing_docs as warn-only for that file. If you can do it, please :) but otherwise it'll probably get done the next time the windows code is touched. |
If it's not blocking anything, then I'm just going to abstain for now. Actively in the middle of another project :). Thanks again for merging! |
This adds documentation to the public APIs. I tried to highlight any backend specific gotchas in a couple of cases (such as which errors can be generated from where).
There are a few things I found that shouldn't really be part of the public API, but those can't be resolved until a new major version; I'll file another issue to address that.
This change is