feat: typescript #56
Merged
feat: typescript #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update prettierrc.config.js I did this to make the files more consistent * Revert "Update prettierrc.config.js" This reverts commit a48336d. * Update prettierrc.config.js * Renamed prettier config properly https://prettier.io/docs/en/configuration.html * Hit the most important files with prettier, to avoid mixing prettier corrections with real changes later * Added typescript, and also a very open tsconfig This should lay a foundation for future update, but they should be done incrementally * Added ts supprt and fixed a type declaration path mistake Updated jest, added babel typescript for jest, added a type to CartProvider * Update prettier.config.js Co-authored-by: Jamie Barton <jamie@notrab.dev> * Update prettier.config.js Co-authored-by: Jamie Barton <jamie@notrab.dev> * Update prettier.config.js Co-authored-by: Jamie Barton <jamie@notrab.dev> * Update prettier.config.js Co-authored-by: Jamie Barton <jamie@notrab.dev> * Update prettier.config.js Co-authored-by: Jamie Barton <jamie@notrab.dev> * Update src/useLocalStorage.ts Co-authored-by: Jamie Barton <jamie@notrab.dev> * Update src/useLocalStorage.ts Co-authored-by: Jamie Barton <jamie@notrab.dev> * Added some of the updates * Added * as React * Added some interfaces, some strictness, some looseness * Fixed typo * Added optional on the CartProvider props * Missed an any, will need a proper type * Added payload, instead of item * Fixed typo * Turned on "noImplicitAny": true, "strictNullChecks": true, and "forceConsistentCasingInFileNames": true, * Changed the last flags to true. TS is fully strict now. * Stronger typed CartProvider props * Little stronger storage type Co-authored-by: Jamie Barton <jamie@notrab.dev>
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@all-contributors please add @getTobiasNielsen for code |
|
I've put up a pull request to add @getTobiasNielsen! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.