Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: PATCH /v1/widgets/preferences/<workflow-id> doesn't return workflow tags #7254

Open
1 of 4 tasks
chuma opened this issue Dec 9, 2024 · 2 comments
Open
1 of 4 tasks
Labels

Comments

@chuma
Copy link

chuma commented Dec 9, 2024

  • I'm submitting a...

    • bug report
    • feature request
    • question about the decisions made in the repository
    • question about how to use this project
  • Summary

PATCH /v1/widgets/preferences/<workflow-id> stopped returning the tags property for the template object in the response.

This is observed on the current Novu Cloud deployment, and was first observed on 2024 Nov 19

This change, when combined with:

  • the v0.24.2 React notification component
  • using workflow tags for filtering via the preferenceFilter prop of the NotificationCenter

Can cause entries to disappear from the preferences pane immediately after toggling a preference.

  • Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

Root cause seems to be that the template object is now formed here, but does not set the tags property. Introduced in #6889

@github-actions github-actions bot added the triage label Dec 9, 2024
@chuma
Copy link
Author

chuma commented Dec 9, 2024

novu-issue-7254-fix.patch

Untested, but this should add the missing tags prop from the affected endpoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant