Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass -q to curl calls to disable user .curlrc files #2613

Merged
merged 1 commit into from
Feb 4, 2021
Merged

pass -q to curl calls to disable user .curlrc files #2613

merged 1 commit into from
Feb 4, 2021

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Feb 3, 2021

this will make the install.sh script a little easier for any users who happen to have a .curlrc that alters the default behavior in a way we do not expect

References

Related to #2599 (comment)

@nlf nlf requested a review from a team as a code owner February 3, 2021 21:01
wraithgar
wraithgar requested changes Feb 3, 2021
View reviewed changes
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may as well make the example in the readme match this too or else they'll never GET to this point if this is a problem.

ljharb
ljharb approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 ty (including the readme change)

@nlf
Copy link
Contributor Author

nlf commented Feb 4, 2021

tweaked the README too

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Feb 4, 2021
@ruyadorno ruyadorno changed the base branch from latest to release/v7.5.3 February 4, 2021 23:10
@ruyadorno ruyadorno merged commit b544e27 into release/v7.5.3 Feb 4, 2021
@ruyadorno ruyadorno mentioned this pull request Feb 4, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Feb 5, 2021
@nlf @ruyadorno
pass -q to curl calls to disable user .curlrc files
6d7afb0 
PR-URL: #2613
Credit: @nlf
Close: #2613
Reviewed-by: @ljharb, @wraithgar
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2021
Closed
@feelepxyz feelepxyz mentioned this pull request Feb 9, 2021
Merged
@nlf nlf deleted the nlf/curl-fix branch March 28, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nlf @wraithgar @ljharb @ruyadorno @darcyclarke