Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): fix noproxy #3508

Merged
merged 1 commit into from
Jul 12, 2021
Merged

fix(config): fix noproxy #3508

merged 1 commit into from
Jul 12, 2021

Conversation

wraithgar
Copy link
Member

The flattener worked for everything except for when you are using
npm config set itself. Now it works for both.

References

Closes #3506

@wraithgar wraithgar requested a review from a team as a code owner July 2, 2021 13:56
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes labels Jul 12, 2021
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is clearly correct

The flattener worked for everything except for when you are using
`npm config set` itself.  Now it works for both.

PR-URL: #3508
Credit: @wraithgar
Close: #3508
Reviewed-by: @nlf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants