Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Exclude more redundant files from the tarball #495

Closed
XhmikosR opened this issue Nov 18, 2019 · 7 comments
Closed

[BUG] Exclude more redundant files from the tarball #495

XhmikosR opened this issue Nov 18, 2019 · 7 comments
Labels
Bug thing that needs fixing

Comments

@XhmikosR
Copy link
Contributor

I mentioned this in #461 too

it seems there are many seemingly unneeded files like .eslintrc, .travis.yml etc.

Now, I know the aforementioned files are not big, but IMO the tarball should be as slim as possible.

@ljharb
Copy link
Contributor

ljharb commented Nov 18, 2019

They are not necessarily redundant. All of my packages explicitly include these files, so that npm explore foo && npm install && npm test always works. npm implicitly excluding these files will break that use case.

@XhmikosR
Copy link
Contributor Author

I just mentioned 2 files as an example. I'm not familiar with what is needed, so this issue is mostly for npm maintainers to have another look at the shipped files.

@ljharb
Copy link
Contributor

ljharb commented Nov 18, 2019

That's up to them; npm itself shouldn't have an opinion here.

@XhmikosR
Copy link
Contributor Author

If the npm maintainers don't know which files are needed, who does?

@ljharb
Copy link
Contributor

ljharb commented Nov 19, 2019

Only the author of the package knows what files are needed, and the current status is that the author decides - via files or .npmignore.

@XhmikosR
Copy link
Contributor Author

I don't see why we keep discussing this TBH. This is mostly a callout for npm developers to have a further look if there are more files that should be excluded from npm's own package like #461...

If everything that's currently included is needed, then the issue can be closed.

@ljharb
Copy link
Contributor

ljharb commented Nov 20, 2019

Sorry, that wasn’t clear to me from the issue title and OP.

@darcyclarke darcyclarke added the Bug thing that needs fixing label Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing
Projects
None yet
Development

No branches or pull requests

3 participants