From 4f801d8a476f7ca52b0f182bf4e17a80db12b4e2 Mon Sep 17 00:00:00 2001 From: Rebecca Turner Date: Wed, 25 Jul 2018 21:15:24 -0700 Subject: [PATCH 1/2] doc: file-specifier: Remove stray comment --- doc/spec/file-specifiers.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/doc/spec/file-specifiers.md b/doc/spec/file-specifiers.md index 226f6d0136728..e8d992d86db31 100644 --- a/doc/spec/file-specifiers.md +++ b/doc/spec/file-specifiers.md @@ -55,9 +55,6 @@ note for the `npm-shrinkwrap.json` as it means the specifier there will be different then the original `package.json` (where it was relative to that `package.json`). -# No, for `file:` type specifiers, we SHOULD shrinkwrap. Other symlinks we -# should not. Other symlinks w/o the link spec should be an error. - When shrinkwrapping file specifiers, the contents of the destination package's `node_modules` WILL NOT be included in the shrinkwrap. If you want to lock down the destination package's `node_modules` you should create a shrinkwrap for it From f4a97b921e886bf0d6ce250e5872a1eb5fa090c3 Mon Sep 17 00:00:00 2001 From: Joe Bowbeer Date: Sat, 28 Jul 2018 22:06:12 -0700 Subject: [PATCH 2/2] Update npm-config.md Remove publish from list of commands not affected by dry-run --- doc/misc/npm-config.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/misc/npm-config.md b/doc/misc/npm-config.md index 45aaf9be9df2c..20ce672d691db 100644 --- a/doc/misc/npm-config.md +++ b/doc/misc/npm-config.md @@ -331,8 +331,8 @@ Install `dev-dependencies` along with packages. Indicates that you don't want npm to make any changes and that it should only report what it would have done. This can be passed into any of the commands that modify your local installation, eg, `install`, `update`, -`dedupe`, `uninstall`. This is NOT currently honored by network related -commands, eg `dist-tags`, `owner`, `publish`, etc. +`dedupe`, `uninstall`. This is NOT currently honored by some network related +commands, eg `dist-tags`, `owner`, etc. ### editor