fix(index): remove extraneous logging on Windows (#136)

Windows logs the path to the downloaded module, which doesn't match Unix behavior. Fixes: #131
npm · Dec 3, 2017 · 357e6ab · 357e6ab
1 parent 93c86e3
commit 357e6ab
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -351,7 +351,7 @@ function findNodeScript (existing, opts) {
           return str.match(cmd) || str.match(mingw)
         }).then(match => {
           return match && path.join(path.dirname(existing), match[1])
-        }).then(x => console.log(x) || x)
+        })
       }
     })
   }

diff --git a/test/index.js b/test/index.js
@@ -270,3 +270,14 @@ test('npx with custom installer stdio', t => {
     t.end()
   })
 })
+
+test('noisy npx with --quiet arg on windows', {
+  skip: !isWindows && 'Only on Windows does the path to the downloaded module get printed'
+}, t => {
+  return child.spawn('node', [
+    NPX_ESC, '--quiet', 'echo-cli', 'hewwo'
+  ], {stdio: 'pipe'}).then(res => {
+    t.equal(res.stdout.trim(), 'hewwo')
+    t.end()
+  })
+})