-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Better dark mode support #4
Comments
Related (or maybe even overlapping?):
Further related discussion: |
Those issues are about C# plugins, for which there is no native solution, as determined here, here and here. In fact, C# edit controls already go dark without any patching; with labels and buttons, the current behaviour is opposite to what happens with C++ plugins: The other issues are at best complementary to the C++ plugin issue, meaning they touch on everything not related to the C++ plugins: In other words, they're completely unrelated. |
Hmm, I think the addition of the Venn diagram in the above is basically saying to me: "You're stupid". If that was the intent, well, thanks for that. :-) Apparently there are "dark mode" complications for both C++ and C# plugin developers; if that's the commonality, then I'll stand by my comment making those complications "related". |
@alankilborn |
Description of the Issue
Dark mode is ignored (i.e., lack of any specific code for handling it) in the 4.3 version of the demo plugin template. Thus when doing some fairly simple UI development in a plugin using the template, not all UI elements appear "dark".
Ideally, a plugin developer should not be impacted (too much) to provide a fully dark-mode enabled plugin, certainly not for a simple UI case like provided below.
Steps to Reproduce the Issue
GROUPBOX "",IDC_GROUPBOX,0,0,180,180
togoLine.rc
#define IDC_GROUPBOX (IDD_PLUGINGOLINE_DEMO + 6)
toresource.h
GotoLineDlg.cpp
(at the obvious spot):Expected Behavior
I expected the edit box for the line number input to be "dark".
Actual Behavior
The edit box for the line number input was "bright white":
Debug Information
plugin demo v.4.3
Running under:
Notepad++ v8.5.2 (64-bit)
Build time : Apr 4 2023 - 19:55:32
Path : W:\npp.misc_NoBackup\Releases\npp.8.5.2\npp.8.5.2.portable.x64\notepad++.exe
Command Line : -titleAdd="8.5.2 64-bit" -multiInst
Admin mode : OFF
Local Conf mode : ON
Cloud Config : OFF
OS Name : Windows 10 Enterprise (64-bit)
OS Version : 21H2
OS Build : 19044.2728
Current ANSI codepage : 1252
Plugins :
ColumnsPlusPlus (0.2.0.6)
mimeTools (2.9)
NppConverter (4.5)
NppExport (0.4)
NppPluginDemo (4.3)
PythonScript (2)
The text was updated successfully, but these errors were encountered: