Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify dose units in edknrc #1032

Open
mchamberland opened this issue Jul 12, 2023 · 1 comment
Open

Specify dose units in edknrc #1032

mchamberland opened this issue Jul 12, 2023 · 1 comment
Assignees
Milestone

Comments

@mchamberland
Copy link
Contributor

mchamberland commented Jul 12, 2023

As far as I can tell, edknrc cavity dose output does not indicate the units of the results. In fact, neither the code documentation nor PIRS-702 mention the units of any of the outputs or whether the results are normalized.

On a related note, line 3836 of the source code indicates "dose per incident particle", with units of "Gy", but I wonder if it would be better to explicitly specify the units as "Gy per incident particle". Leaving it as "Gy" is ambiguous and may lead to confusion as to the results. But perhaps that's a wider discussion to be had across EGSnrc?

@ftessier
Copy link
Member

Agreed that the units ought to be spelled out everywhere. I am fine with Gy units for "dose per incident particle", but it would do no harm to state that explicitly too.

@ftessier ftessier added this to the Release 2024 milestone Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants