-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
middleware doesn't load with trampoline
?
#34
Comments
Yeah, trampoline has consistently posed a challenge for various plugins (emezeske/lein-cljsbuild#204 is another issue I'm aware of). I can reproduce the problem you describe, and you're correct about the proximate cause (the middleware hasn't been loaded). Happy to take a PR, though from what I understand of trampoline, its environment is subtly (but sufficiently) different from "normal" task execution that getting piggieback to work with it properly may not be feasible/worth the effort? |
Thanks for looking into it. Since I know next to nothing about the inner workings of lein, I'll defer to your judgment on it not being worth it. Would you take a PR that provided a better error message about the possible causes of that error? |
There's a similar issue at greglook/whidbey#6 where @trptcolin speculates that trampoline repl fails to load middleware at all. Perhaps it's worth logging this on the leiningen issue tracker? |
I realize this may not be an issue in Piggieback itself, but I figured this would still be the right place to bring it up. When I do
lein repl
, I can bring up my browser repl no problem (I'm using Weasel, not Piggieback directly, but AFAIK that doesn't matter). But when I dolein trampoline repl
and do the same thing, I get:Reading through the issues here, I understand that error means the nrepl-middleware hasn't loaded? Is there something about the way
trampoline
works that creates a problem there?The text was updated successfully, but these errors were encountered: