fix(nx): increases buffer size for git commands

increases buffer size to 10MB fix #1886
nrwl · Oct 1, 2019 · adcd928 · adcd928
1 parent 4b4a5dc
commit adcd928
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/packages/workspace/src/builders/run-commands/run-commands.impl.ts b/packages/workspace/src/builders/run-commands/run-commands.impl.ts
@@ -1,11 +1,12 @@
 import {
-  createBuilder,
   BuilderContext,
-  BuilderOutput
+  BuilderOutput,
+  createBuilder
 } from '@angular-devkit/architect';
-import { Observable } from 'rxjs';
-import { exec } from 'child_process';
 import { JsonObject } from '@angular-devkit/core';
+import { exec } from 'child_process';
+import { Observable } from 'rxjs';
+import { TEN_MEGABYTES } from '../../command-line/shared';
 
 try {
   require('dotenv').config();
@@ -136,7 +137,6 @@ function createProcess(
 ): Promise<boolean> {
   command = transformCommand(command, parsedArgs);
   return new Promise(res => {
-    const TEN_MEGABYTES = 1024 * 10000;
     const childProcess = exec(command, { maxBuffer: TEN_MEGABYTES });
     /**
      * Ensure the child process is killed when the parent exits

diff --git a/packages/workspace/src/command-line/shared.ts b/packages/workspace/src/command-line/shared.ts
@@ -19,6 +19,8 @@ import { output } from './output';
 
 const ignore = require('ignore');
 
+export const TEN_MEGABYTES = 1024 * 10000;
+
 export type ImplicitDependencyEntry = { [key: string]: '*' | string[] };
 export type NormalizedImplicitDependencyEntry = { [key: string]: string[] };
 export type ImplicitDependencies = {
@@ -141,7 +143,9 @@ function getUntrackedFiles(): string[] {
 }
 
 function getFilesUsingBaseAndHead(base: string, head: string): string[] {
-  const mergeBase = execSync(`git merge-base ${base} ${head}`)
+  const mergeBase = execSync(`git merge-base ${base} ${head}`, {
+    maxBuffer: TEN_MEGABYTES
+  })
     .toString()
     .trim();
   return parseGitOutput(`git diff --name-only ${mergeBase} ${head}`);
@@ -152,7 +156,7 @@ function getFilesFromShash(sha1: string, sha2: string): string[] {
 }
 
 function parseGitOutput(command: string): string[] {
-  return execSync(command)
+  return execSync(command, { maxBuffer: TEN_MEGABYTES })
     .toString('utf-8')
     .split('\n')
     .map(a => a.trim())