Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): fix remote generation devServerPort #18603

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix(react): fix remote generation devServerPort #18603

merged 1 commit into from
Aug 21, 2023

Conversation

nadavshatz
Copy link
Contributor

Removed the default 4200 value from the remote generator.

It was being used for all remotes instead of using the calculation.

Current Behavior

running nx g react:remote some-app --host=some-host will always result with the devServerPort being set on 4200.

Expected Behavior

running nx g react:remote some-app --host=some-host will result with the devServerPort being set on 420x dependent on the latest port available.

@nadavshatz nadavshatz requested a review from a team as a code owner August 13, 2023 07:52
@vercel
Copy link

vercel bot commented Aug 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 8:38am

@nadavshatz nadavshatz requested a review from a team as a code owner August 13, 2023 07:54
Removed the default 4200 value from the remote generator.

It was being used for all remotes instead of using the calculation.
@mandarini mandarini merged commit 1a0962f into nrwl:master Aug 21, 2023
3 checks passed
FrozenPandaz pushed a commit that referenced this pull request Aug 21, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
@nadavshatz nadavshatz deleted the fix/react-remote-port branch August 27, 2023 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants