feat(angular): use helper to determine project name and root directory in project generators #18607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
force-pushed
the
angular/library-use-name-root-helper
branch
from
f0424db
to
f52861e
Compare
leosvelperez
changed the title
FrozenPandaz
previously requested changes
Aug 14, 2023
| @@ -571,7 +571,7 @@ describe('lib', () => { | |||
| it('should accept numbers in the path', async () => { | |||
| await runLibraryGeneratorWithOpts({ directory: 'src/1-api' }); | |||
|
|
|||
| expect(readProjectConfiguration(tree, 'src-api-my-lib').root).toEqual( | |||
| expect(readProjectConfiguration(tree, 'src-1-api-my-lib').root).toEqual( | |||
There was a problem hiding this comment.
How come this changed?
There was a problem hiding this comment.
We used to have a restriction on numbers which no longer applies. This applied only to Angular projects, but it doesn't anymore.
…directory for libraries
…y in application generator
leosvelperez
force-pushed
the
angular/library-use-name-root-helper
branch
from
f52861e
to
cd023cb
Compare
leosvelperez
changed the title
leosvelperez
commented
Aug 16, 2023
Coly010
approved these changes
Aug 16, 2023
leosvelperez
force-pushed
the
angular/library-use-name-root-helper
branch
from
f06619f
to
e6c7da8
Compare
AgentEnder
approved these changes
Aug 17, 2023
leosvelperez
force-pushed
the
angular/library-use-name-root-helper
branch
from
e6c7da8
to
464633e
Compare
…r function" This reverts commit 464633e.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Angular plugin project generators (application, host, remote and library) to use the helper to determine the project name and root.
For more context on the changes, see: #18420
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #