-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nextjs): make next build package manager agnostic #18661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ndcunningham
force-pushed
the
fix/next-yarn-build
branch
from
August 16, 2023 19:34
716d851
to
7d1e089
Compare
meeroslav
reviewed
Aug 17, 2023
meeroslav
reviewed
Aug 17, 2023
meeroslav
reviewed
Aug 17, 2023
meeroslav
reviewed
Aug 17, 2023
meeroslav
reviewed
Aug 17, 2023
meeroslav
requested changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor changes needed, otherwise it's good.
ndcunningham
force-pushed
the
fix/next-yarn-build
branch
from
August 17, 2023 15:07
7d1e089
to
f29afa9
Compare
ndcunningham
force-pushed
the
fix/next-yarn-build
branch
from
August 17, 2023 15:11
f29afa9
to
585306f
Compare
meeroslav
approved these changes
Aug 17, 2023
ndcunningham
force-pushed
the
fix/next-yarn-build
branch
from
August 17, 2023 15:59
585306f
to
db3c52d
Compare
xiongemi
approved these changes
Aug 17, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 18, 2023
(cherry picked from commit 2e1bccd)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed:
Instead of running different build commands based on the package manager we can invoke the command directly from the bin.
closed #18653