Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): format must exclude ignored patterns #18670

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

pongells
Copy link
Contributor

nx format commands will now correctly ignore
patterns defined in .gitignore or .nxignore

Current Behavior

The nx format commands (write, check) do not take into account ignored patterns.

Expected Behavior

The nx format commands (write, check) should not parse ignored patterns.

Related Issue(s)

#18568

Fixes #18568

`nx format` commands will now correctly ignore
patterns defined in `.gitignore` or `.nxignore`
@pongells pongells requested a review from a team as a code owner August 17, 2023 09:03
@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 1:16pm

@pongells pongells changed the title fix(misc): format must exclude ignored patterns (#18568) fix(misc): format must exclude ignored patterns Aug 17, 2023
@pongells
Copy link
Contributor Author

@Cammisuli is there something missing?

@Cammisuli Cammisuli merged commit c479a54 into nrwl:master Aug 22, 2023
3 checks passed
FrozenPandaz pushed a commit that referenced this pull request Aug 23, 2023
Co-authored-by: Stefano Pongelli <stefano.pongelli@eligamo.com>
(cherry picked from commit c479a54)
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

format:check parses file excluded via .nxignore / .gitignore
4 participants