-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(detox): use helper to determine project name and root in application generator #18674
Merged
FrozenPandaz
merged 4 commits into
nrwl:master
from
leosvelperez:detox/use-name-root-helper
Aug 21, 2023
Merged
feat(detox): use helper to determine project name and root in application generator #18674
FrozenPandaz
merged 4 commits into
nrwl:master
from
leosvelperez:detox/use-name-root-helper
Aug 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
force-pushed
the
detox/use-name-root-helper
branch
from
August 17, 2023 14:29
1e61202
to
33e4636
Compare
leosvelperez
force-pushed
the
detox/use-name-root-helper
branch
from
August 18, 2023 08:46
33e4636
to
4f6205f
Compare
leosvelperez
force-pushed
the
detox/use-name-root-helper
branch
from
August 18, 2023 09:20
4f6205f
to
b8eac44
Compare
leosvelperez
force-pushed
the
detox/use-name-root-helper
branch
from
August 18, 2023 12:50
b8eac44
to
27fcbc5
Compare
leosvelperez
force-pushed
the
detox/use-name-root-helper
branch
from
August 18, 2023 15:23
27fcbc5
to
9125024
Compare
leosvelperez
force-pushed
the
detox/use-name-root-helper
branch
from
August 21, 2023 07:35
9125024
to
c33b5f4
Compare
xiongemi
approved these changes
Aug 21, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Detox plugin application generator to use the helper to determine the project name and root.
For more context on the changes, see: #18420
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #