Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handle symlinks better for watch events on arch #18743

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

Cammisuli
Copy link
Member

Current Behavior

Watch events on arch could potentially not resolve symlink files. As seen in this issue watchexec/watchexec#508

Expected Behavior

Watch events on Arch will now create a new event to map paths to their real paths

Related Issue(s)

Fixes #

@Cammisuli Cammisuli requested review from a team as code owners August 21, 2023 13:33
@vercel
Copy link

vercel bot commented Aug 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 1:39pm

@FrozenPandaz FrozenPandaz merged commit f230078 into nrwl:master Aug 21, 2023
3 checks passed
FrozenPandaz pushed a commit that referenced this pull request Aug 21, 2023
@Cammisuli Cammisuli deleted the add_arch_check_for_symlinks branch August 24, 2023 12:31
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants