Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): use textarea for prompts and show a better "no results"error #18798

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Aug 23, 2023

This PR makes the AI chat prompt a textarea so code snippets can be pasted. Also improves the "no results" message to be less jarring.

Try it: https://nx-dev-git-fork-jaysoo-feat-ai-textarea-and-better-errors-nrwl.vercel.app/ai

ai-page.mp4

@jaysoo jaysoo requested review from a team as code owners August 23, 2023 18:56
@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 0:34am

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we add some padding-right to save room for the submit button? Can we have the submit button on the bottom right?

@jaysoo jaysoo force-pushed the feat/ai-textarea-and-better-errors branch from aa7ef14 to 3b6f83c Compare August 25, 2023 12:27
@jaysoo
Copy link
Member Author

jaysoo commented Aug 25, 2023

@FrozenPandaz Done
Screenshot 2023-08-25 at 8 27 21 AM

@FrozenPandaz FrozenPandaz merged commit e4755cb into nrwl:master Aug 25, 2023
3 checks passed
@jaysoo jaysoo deleted the feat/ai-textarea-and-better-errors branch August 25, 2023 14:38
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants