Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): check for lerna before parsing lockfiles to prevent errors #18884

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Aug 29, 2023

Running Nx before dependencies are installed can result in an error during lockfile parsing.

Addresses lerna/lerna#3807

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner August 29, 2023 14:01
@jaysoo jaysoo requested a review from Cammisuli August 29, 2023 14:01
@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2023 2:49pm

@jaysoo jaysoo force-pushed the fix/lockfile-for-lerna branch 4 times, most recently from fc85024 to c46a802 Compare August 29, 2023 14:25
Running Nx before dependencies are installed can result in an error
during lockfile parsing.
@FrozenPandaz FrozenPandaz merged commit e188775 into nrwl:master Aug 29, 2023
3 checks passed
@jaysoo jaysoo deleted the fix/lockfile-for-lerna branch August 29, 2023 16:09
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants