fix(nextjs): Deprecate adding NX_ vars to Webpack Define #18892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaysoo
reviewed
Aug 29, 2023
When we add NX_ vars to Webpack Define it would be available to both client and server. This does not follow Next.js' concept to only add environment variables prefixed with NEXT_PUBLIC_ to the client As such to get acces to environment variables declared in the .env file consumers should use the NEXT_ or NEXT_PUBLIC_ prefix closes: nrwl#17940
ndcunningham
force-pushed
the
chore/add-warning-next-env
branch
from
8f598d7
to
b6f9943
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added NX_ vars to Webpack Define it would be available to both the client and server. This does not follow Next.js' concept to only add environment variables prefixed with
NEXT_PUBLIC_to the client.Now if a
NX_var was found and it is not a Nx defined variable the console will warn with:After Nx 18, to get access to environment variables declared in the
.envfile consumers should use theNEXT_orNEXT_PUBLIC_prefix.closes: #17940