Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): merge implicit project dependencies only if found on new and matching projects #18896

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

AgentEnder
Copy link
Member

Current Behavior

A typo when merging project nodes may cause an error when implicitDependencies is not specified on one of them, as a null check checks the wrong property.

Expected Behavior

The merge only happens if both sides have the property

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested a review from a team as a code owner August 29, 2023 20:42
@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 9:38pm

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) August 29, 2023 20:46
@FrozenPandaz FrozenPandaz merged commit 7e50274 into nrwl:master Aug 29, 2023
3 checks passed
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants