Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): Update typings and fix when converting lib to vite #18956

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

ndcunningham
Copy link
Contributor

This PR contains the following:

  • Update react plugin tsconfig's to support Yarn PnP
  • Update vite configuration generator to ensure 'vite/client' type is included so that you can build vite-based libraries
  • Update vite libs tsconfig.lib.json to compile only src/* similar to what vite application does

@ndcunningham ndcunningham added the scope: react Issues related to React support for Nx label Sep 1, 2023
@ndcunningham ndcunningham requested a review from a team as a code owner September 1, 2023 01:15
@ndcunningham ndcunningham self-assigned this Sep 1, 2023
@ndcunningham ndcunningham requested a review from a team as a code owner September 1, 2023 01:15
@vercel
Copy link

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 2:41pm

@jaysoo jaysoo enabled auto-merge (squash) September 1, 2023 13:27
@jaysoo jaysoo merged commit 8f1429d into nrwl:master Sep 1, 2023
3 checks passed
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: react Issues related to React support for Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants