fix(nx): update storybook configuration #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacplmann
force-pushed
the
storybook-migrate-8-8-2
branch
from
acbcb88 to
f86b724
Compare
|
Looks good. Just one test failure to fix in CI and then we should be good to go. |
isaacplmann
force-pushed
the
storybook-migrate-8-8-2
branch
from
f86b724 to
ceb50a3
Compare
FrozenPandaz
approved these changes
Nov 29, 2019
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior (This is the behavior we have today, before the PR is merged)
nx affected --target e2ewill run storybook e2e builder tasks in watch mode, but standard Cypress e2e tasks not in watch mode.providedIn: 'root'can't find the serviceExpected Behavior (This is the new behavior we can expect after the PR is merged)
e2eis not in watch modetsconfig.jsonsetsemitDecoratorMetadatatotrueso services provided in root can be found by Storybook.