fix(core): cypress & fork ts checker plugin #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcabanes
force-pushed
the
fix/cypress-ts-fork-checker
branch
from
164e178 to
35ae469
Compare
|
@FrozenPandaz Do you think i should add a migration script? |
|
@bcabanes what would the migration script do? |
bcabanes
force-pushed
the
fix/cypress-ts-fork-checker
branch
2 times, most recently
from
1ab8f61 to
06d48ba
Compare
bcabanes
force-pushed
the
fix/cypress-ts-fork-checker
branch
from
06d48ba to
4a2b902
Compare
|
@vsavkin No migration needed after all. |
FrozenPandaz
approved these changes
Jan 24, 2020
elliottsj
added a commit
to Yolk-HQ-old/nx
that referenced
this pull request
Feb 20, 2020
elliottsj
added a commit
to Yolk-HQ-old/nx
that referenced
this pull request
Feb 20, 2020
chore(core): port nrwl#2316
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour (This is the behaviour we have today, before the PR is merged)
The combination of
fork-ts-checker-webpack-pluginand the use ofsupportFileproperty in thecypress.jsonfile, was causing cypress to hang probably because a process was not being killed properly. Thus, we switched back tots-loaderto do type checking but that causes memory issues.Expected behaviour (This is the new behaviour we can expect after the PR is merged)
Because of the memory issues, we bringing back
fork-ts-checker-webpack-pluginbut adding a twist: compiling file by file instead of parallel.That way Cypress is not hanging for a process that never end, and the memory issue should be resolved.
Issue
fixes #2103
fixes #2217
fixes #2009