fix(angular): update defaults for NgRx schematics #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: The minimal flag is set to true The syntax flag is set to creators The useDataPersistence flag is set to false BEFORE: By default, the root Store and Effects modules are registered, with a generated feature By default, the action classes syntax is used for scaffolding By default, the DataPersistence class in injected and used in Effects AFTER: By default, only the root Store and Effects modules are registered By default, the creator functions are used for scaffolding with schematics By default, the DataPersistence operators are used in Effects
brandonroberts
force-pushed
the
fix-ngrx-flags
branch
from
0b7ce31 to
8f40e39
Compare
FrozenPandaz
approved these changes
Feb 6, 2020
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure you have read the submission guidelines before posting an PR
Current Behavior (This is the behavior we have today, before the PR is merged)
By default, the root Store and Effects modules are registered, with a generated feature
By default, the action classes syntax is used for scaffolding
By default, the DataPersistence class in injected and used in Effects
Expected Behavior (This is the new behavior we can expect after the PR is merged)
By default, only the root Store and Effects modules are registered
By default, the creator functions are used for scaffolding with schematics
By default, the DataPersistence operators are used in Effects
Issue