fix(core): perform package.json update if one of the deps is missing #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juristr
approved these changes
Feb 14, 2020
4 tasks
vsavkin
pushed a commit
that referenced
this pull request
Feb 20, 2020
…2481) * fix(core): perform package.json update if one of the deps is missing * fix(core): add test for package.json update Co-authored-by: Juri Strumpflohner <juri.strumpflohner@gmail.com>
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create a workspace with web or react presets, Nx does not install additional eslint packages since
eslintis already inpackage.json.This PR updates the logic so if any of the requested dependencies is missing, then the add task will be executed.
Current Behavior (This is the behavior we have today, before the PR is merged)
Running
create-nx-workspace myorg --preset=reactdoes not install eslint plugins soyarn lintfails.Expected Behavior (This is the new behavior we can expect after the PR is merged)
yarn lintworks