Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#21428 removed devDependencies from package.json #26577

Closed
TriPSs opened this issue Jun 17, 2024 · 24 comments
Closed

#21428 removed devDependencies from package.json #26577

TriPSs opened this issue Jun 17, 2024 · 24 comments

Comments

@TriPSs
Copy link
Contributor

TriPSs commented Jun 17, 2024

Why? Why is this not made optional (or at-least make this behavior opt in?), as a lib maintainer we add dev dependencies so that

  1. the package is available when we are developing
  2. we can import the package.json and copy it over if needed to the devDependencies of the users project
  3. we can use a tool like ncu to easy update set packages that are added to the users project
  4. we are then not forcing certain versions to our end users

Can we make this behavior opt-in or opt-out?

@TriPSs TriPSs changed the title #21428 removed devDependencies from pacakge.json #21428 removed devDependencies from package.json Jun 17, 2024
@TriPSs
Copy link
Contributor Author

TriPSs commented Jun 17, 2024

#21428, made this ticket with the reference in issue function, sorry that it's not following the format.

@FrozenPandaz
Copy link
Collaborator

What are you running where you are seeing the issue? Can you provide a reproduction please to help us reproduce the issue?

@TriPSs
Copy link
Contributor Author

TriPSs commented Jun 25, 2024

Here is the commit that changes the implementation we had. These packages where build and released with devDependencies so when running the <package>:init we could read it from there.

We can keep dependencies inside the package.json up to date with tools like ncu, now it will become a manual stap, which will be forgotten.

Copy link

github-actions bot commented Jul 3, 2024

This issue has been automatically marked as stale because more information has not been provided within 7 days.
It will be closed in 21 days if no information is provided.
If information has been provided, please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Jul 3, 2024
@TriPSs
Copy link
Contributor Author

TriPSs commented Jul 3, 2024

I did add more info?

@github-actions github-actions bot removed the stale label Jul 4, 2024
Copy link

This issue has been automatically marked as stale because more information has not been provided within 7 days.
It will be closed in 21 days if no information is provided.
If information has been provided, please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Jul 11, 2024
@TriPSs
Copy link
Contributor Author

TriPSs commented Jul 11, 2024

Again, I did add more info.

@github-actions github-actions bot removed the stale label Jul 12, 2024
Copy link

This issue has been automatically marked as stale because more information has not been provided within 7 days.
It will be closed in 21 days if no information is provided.
If information has been provided, please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Jul 19, 2024
@TriPSs
Copy link
Contributor Author

TriPSs commented Jul 21, 2024

Once again, I did add more info @FrozenPandaz

@github-actions github-actions bot removed the stale label Jul 22, 2024
Copy link

This issue has been automatically marked as stale because more information has not been provided within 7 days.
It will be closed in 21 days if no information is provided.
If information has been provided, please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Jul 29, 2024
@TriPSs
Copy link
Contributor Author

TriPSs commented Jul 29, 2024

@jaysoo @FrozenPandaz

@github-actions github-actions bot removed the stale label Jul 30, 2024
Copy link

github-actions bot commented Aug 6, 2024

This issue has been automatically marked as stale because more information has not been provided within 7 days.
It will be closed in 21 days if no information is provided.
If information has been provided, please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Aug 6, 2024
@TriPSs
Copy link
Contributor Author

TriPSs commented Aug 6, 2024

:/

@github-actions github-actions bot removed the stale label Aug 7, 2024
Copy link

This issue has been automatically marked as stale because more information has not been provided within 7 days.
It will be closed in 21 days if no information is provided.
If information has been provided, please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Aug 14, 2024
@TriPSs
Copy link
Contributor Author

TriPSs commented Aug 14, 2024

:/

@github-actions github-actions bot removed the stale label Aug 15, 2024
Copy link

This issue has been automatically marked as stale because more information has not been provided within 7 days.
It will be closed in 21 days if no information is provided.
If information has been provided, please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Aug 22, 2024
@TriPSs
Copy link
Contributor Author

TriPSs commented Aug 25, 2024

Bump again

@github-actions github-actions bot removed the stale label Aug 26, 2024
Copy link

github-actions bot commented Sep 2, 2024

This issue has been automatically marked as stale because more information has not been provided within 7 days.
It will be closed in 21 days if no information is provided.
If information has been provided, please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Sep 2, 2024
@TriPSs
Copy link
Contributor Author

TriPSs commented Sep 2, 2024

Bump again

@github-actions github-actions bot removed the stale label Sep 3, 2024
Copy link

This issue has been automatically marked as stale because more information has not been provided within 7 days.
It will be closed in 21 days if no information is provided.
If information has been provided, please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Sep 10, 2024
@TriPSs
Copy link
Contributor Author

TriPSs commented Sep 10, 2024

Once again, not stale @FrozenPandaz

@github-actions github-actions bot removed the stale label Sep 11, 2024
Copy link

This issue has been automatically marked as stale because more information has not been provided within 7 days.
It will be closed in 21 days if no information is provided.
If information has been provided, please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Sep 18, 2024
@TriPSs
Copy link
Contributor Author

TriPSs commented Sep 18, 2024

Ok, I give up.

@github-actions github-actions bot removed the stale label Sep 19, 2024
Copy link

This issue has been automatically marked as stale because more information has not been provided within 7 days.
It will be closed in 21 days if no information is provided.
If information has been provided, please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Sep 26, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants