feat(nextjs): allow custom distDir #4885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@myspivey Hey James! I tried this fix, which will allow a user to set a custom |
mandarini
changed the title
Nx Cloud ReportCI ran the following commands for commit b5f3582. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
mandarini
force-pushed
the
feat/nextjs-accept-custom-distDir
branch
from
5244304
to
e6d8902
Compare
mandarini
changed the title
mandarini
changed the title
mandarini
force-pushed
the
feat/nextjs-accept-custom-distDir
branch
from
e6d8902
to
dfcaf20
Compare
mandarini
force-pushed
the
feat/nextjs-accept-custom-distDir
branch
from
dfcaf20
to
b5f3582
Compare
jaysoo
approved these changes
Feb 26, 2021
This was referenced Mar 11, 2021
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Nextjs builder does not take into accound custom
distDirthat users set in theirnext.config.jsfileExpected Behavior
Nextjs builder takes into accound custom
distDirthat users set in theirnext.config.jsfileRelated Issue(s)
Fixes #