chore(nextjs): add migration to remove tsconfig.app.json #4988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirjai
commented
Mar 10, 2021
| const isNextJs = p.targets?.build?.executor === '@nrwl/next:build'; | ||
|
|
||
| const parserOptionsProjectVal = isNextJs | ||
| ? [`${p.root}/tsconfig(.*)?.json`] |
There was a problem hiding this comment.
this is related to a change that was introduced in #4970 , where Next.js apps need this path to be different from other apps
Nx Cloud ReportCI ran the following commands for commit 06ef6fe. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
jaysoo
requested changes
Mar 10, 2021
packages/next/src/migrations/update-11-5-0/remove-tsconfig-app-11-5-0.ts
Show resolved
Hide resolved
additionally, fix linter migration to migrate next.js apps correctly
jaysoo
approved these changes
Mar 10, 2021
This was referenced Mar 11, 2021
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additionally, fix linter migration to migrate next.js apps correctly
Current Behavior
Added migration for changes introduced in #4970
Expected Behavior
Related Issue(s)