Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined attribute warnings on Heroicons component #47

Open
nskins opened this issue Feb 25, 2023 · 0 comments
Open

Fix undefined attribute warnings on Heroicons component #47

nskins opened this issue Feb 25, 2023 · 0 comments
Labels
help wanted Extra attention is needed tech debt Something needs a refactor

Comments

@nskins
Copy link
Owner

nskins commented Feb 25, 2023

Output from mix compile --warnings-as-errors:

warning: undefined attribute "data" for component Heroicons.trash/1
  lib/we_lift_web/live/workout_live/show.ex:31: (file)

warning: undefined attribute "phx_value_id" for component Heroicons.trash/1
  lib/we_lift_web/live/workout_live/show.ex:30: (file)

The strange thing is that these warnings only appear when I compile on my local machine. They are not present during CI builds. The CI build is using Elixir v1.14.3 and OTP v25.1 (which matches what I have locally). So I'm not exactly sure why the two environments have a discrepancy.

Regardless, let's do something to resolve the errors in the local environment. It might be that the Heroicons.trash component needs to be wrapped by a div or something (which will then carry the data and phx_value_id attributes). Need to do a little more research to figure out a true fix.

@nskins nskins added help wanted Extra attention is needed tech debt Something needs a refactor labels Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed tech debt Something needs a refactor
Projects
None yet
Development

No branches or pull requests

1 participant