Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release #785

Closed
blink1073 opened this issue Mar 12, 2024 · 7 comments
Closed

New Release #785

blink1073 opened this issue Mar 12, 2024 · 7 comments

Comments

@blink1073
Copy link
Contributor

Would it be possible to have a release with #748? We're still failing downstream tests in Jupyter projects.

@MSeal
Copy link
Member

MSeal commented Mar 28, 2024

@blink1073 yes, I was out of town recently. But let me get the current two PRs merged and I can roll out a release.

@matthewfeickert
Copy link
Contributor

matthewfeickert commented Apr 2, 2024

This would also be helpful, as you currently can't install papermill with uv given that in v2.5.0 aiohttp was pinned to a pre-release (for Python 3.12)

aiohttp==3.9.0b0;python_version=="3.12"

$ docker run --rm -ti python:3.12 /bin/bash
root@124e91933572:/# python -m venv .venv && . .venv/bin/activate
(.venv) root@124e91933572:/# python -m pip --quiet install uv
(.venv) root@124e91933572:/# uv pip install 'papermill==2.5.0'
  × No solution found when resolving dependencies:
  ╰─▶ Because there is no version of aiohttp==3.9.0b0 and papermill==2.5.0 depends on aiohttp==3.9.0b0, we can conclude that papermill==2.5.0 cannot be used.
      And because you require papermill==2.5.0, we can conclude that the requirements are unsatisfiable.

      hint: aiohttp was requested with a pre-release marker (e.g., aiohttp==3.9.0b0), but pre-releases weren't enabled (try: `--prerelease=allow`)
(.venv) root@124e91933572:/#

c.f. astral-sh/uv#2685 also

Now it has been updated in PR #771 to be pinned to a stable release

aiohttp ==3.9.2; python_version=="3.12"

so a new release should be installable.

Aside: Does aiohttp need to be pinned, instead of just having a lower bound? It isn't clear from a quick glance at PR #733 why this pin was added originally.

@MSeal
Copy link
Member

MSeal commented Apr 2, 2024

It almost certainly doesn't need to be pinned -- there was an issue when 3.12 was new with aiohttp but I am guessing new versions shouldn't be as problematic. If someone has a moment to try that out and give a min version instead of a pin it would help, but I can take a look before making the release (other PRs are merged now, just trying to find an evening to focus on ensuring main is in a good state).

@matthewfeickert
Copy link
Contributor

If someone has a moment to try that out and give a min version instead of a pin it would help, but I can take a look before making the release (other PRs are merged now, just trying to find an evening to focus on ensuring main is in a good state).

Done in PR #789

@mbektas
Copy link
Contributor

mbektas commented Apr 8, 2024

@MSeal any ETA on the new release? I would be happy to help out.

@matthewfeickert
Copy link
Contributor

I fully appreciate that when I do releases for our small library, that even just doing all the backports and checks before we cut a patch release can take multiple hours, and so making a papermill release could be a lot more work. Though if it would be possible to get a new papermill release in May, 2024 that would be great.

@mbektas
Copy link
Contributor

mbektas commented Apr 27, 2024

v2.6.0 is released now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants