-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create conditions errors in code #142
Comments
Nice, this is documentation error, thank you Although I would've absolutely expected you to be able to pass the return value as an int - do you have the exact error? I'm wondering if it's |
Yes, here it is:
|
Perhaps we should have a separate test suite in |
@manumonti is this part of the docs work you did to ensure that the code used in docs is correct? If so, is this completed, and this issue can be closed? And the docs have been updated already? |
Closed by #147 |
I'm not sure if this is a documentation issue or a nucypher-ts bug.
If we check Conditions.RpcCondition docs, we see there are two ways of creating this condition. But both of them return errors if used as described in docs:
If we use in the code the former one, we get an error:
This error is fixed if we pass the Object key
value
as string instead of as number:However, in the latter option, we can use both, string and number types, for the key
value
.Should we homogenize this behavior by allowing only one type (string or number)?
Another issue is that the latter option returns error:
It only works if we delete the two first keys of the config object:
Also, we have the same problems in Conditions.TimelockCondition.
The text was updated successfully, but these errors were encountered: