Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net5 tfm: produce error when missing TPV #9441

Closed
zkat opened this issue Apr 14, 2020 · 3 comments · Fixed by NuGet/NuGet.Client#3616 or NuGet/NuGet.Client#3691
Closed

net5 tfm: produce error when missing TPV #9441

zkat opened this issue Apr 14, 2020 · 3 comments · Fixed by NuGet/NuGet.Client#3616 or NuGet/NuGet.Client#3691
Assignees
@zkat
Labels
Partner:DotNet Priority:2 Issues for the current backlog. Type:DCR Design Change Request
Milestone
Sprint 178 - 2020...

Comments

@zkat
Copy link
Contributor

zkat commented Apr 14, 2020

Produce an error when a OS flavored .NET 5 TFM is consumed but the package has no TPV in either folder name of the manifest. Is this supposed to be during restore??
@zkat zkat added Type:DCR Design Change Request Partner:DotNet labels Apr 14, 2020
@nkolev92 nkolev92 added the Priority:2 Issues for the current backlog. label Apr 16, 2020
@nkolev92
Copy link
Member

nkolev92 commented Jul 6, 2020

Reading the target frameworks in the inner build will make this possible.

@nkolev92 nkolev92 changed the title net5 tfm: produce error when missing TPV net5 tfm: produce error when missing OSVersion Jul 6, 2020
@nkolev92 nkolev92 changed the title net5 tfm: produce error when missing OSVersion net5 tfm: produce error when missing TPV Jul 6, 2020
@zkat
Copy link
Contributor Author

zkat commented Jul 9, 2020

This is pretty small assuming we have #9756 in place :)

@terrajobst terrajobst mentioned this issue Jul 13, 2020
Closed
15 tasks
@zkat zkat self-assigned this Aug 18, 2020
@zkat zkat added this to the Sprint 175 - 2020.08.17 milestone Aug 18, 2020
zkat added a commit to NuGet/NuGet.Client that referenced this issue Aug 28, 2020
@zkat
error when TPV is missing from dependencies
0954642 
Fixes: NuGet/Home#9441
@zkat zkat mentioned this issue Aug 28, 2020
Merged
zkat added a commit to NuGet/NuGet.Client that referenced this issue Sep 8, 2020
@zkat
error when TPV is missing from dependencies
3c5a259 
Fixes: NuGet/Home#9441
heng-liu pushed a commit to NuGet/NuGet.Client that referenced this issue Sep 9, 2020
@zkat
error when TPV is missing from target frameworks (#3616)
d1e99c9 
* error when TPV is missing from dependencies

Fixes: NuGet/Home#9441
heng-liu pushed a commit to NuGet/NuGet.Client that referenced this issue Sep 9, 2020
@zkat @heng-liu
error when TPV is missing from target frameworks (#3616)
f172006 
* error when TPV is missing from dependencies

Fixes: NuGet/Home#9441
@zkat zkat reopened this Sep 15, 2020
@zkat zkat mentioned this issue Sep 21, 2020
Merged
@zkat
Copy link
Contributor Author

zkat commented Oct 8, 2020

current status: I haven't been able to actually get started with rewriting this because I'm still working on #9215

@zkat zkat mentioned this issue Oct 16, 2020
Merged
zkat added a commit to NuGet/NuGet.Client that referenced this issue Oct 21, 2020
@zkat
raise error when missing tpv and platform present (#3691)
11c2bcb 
Fixes: NuGet/Home#9441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zkat zkat

Labels
Partner:DotNet Priority:2 Issues for the current backlog. Type:DCR Design Change Request
Projects
None yet
Milestone
Sprint 178 - 2020.10.19
4 participants
@zkat @nkolev92 @heng-liu @aortiz-msft