Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuclear doesn't download verified streams. #1484

Open
Saltane opened this issue Jul 26, 2023 · 6 comments
Open

Nuclear doesn't download verified streams. #1484

Saltane opened this issue Jul 26, 2023 · 6 comments
Labels
enhancement This thread requests an enhancement to be implemented. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time.

Comments

@Saltane
Copy link

Saltane commented Jul 26, 2023

Platform:
Linux
Nuclear version:
0.6.27 (AUR)
Description of the issue:
Issue is quite simple. There's a track which if unverified plays undesired stream. After verifying named track to desired stream, download feature of Nuclear downloads track from undesired stream mentioned before.
Expected behaviour:
After verifying a track, Nuclear will download correct, verified stream.

@Saltane Saltane added the bug This issue identifies a bug in Nuclear. label Jul 26, 2023
@nukeop nukeop added enhancement This thread requests an enhancement to be implemented. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time. and removed bug This issue identifies a bug in Nuclear. labels Jul 26, 2023
@nukeop
Copy link
Owner

nukeop commented Jul 26, 2023

Since downloading is implemented in a different place, it does not share the code that normally checks the verification service for matches. It should be added there.

@dhananjay-Byte
Copy link

@nukeop i would like to work on this issue. can you assign me this?

@nukeop
Copy link
Owner

nukeop commented Oct 16, 2023

I don't assign issues, but you're free to open a pull request.

@Krishcode264
Copy link

Krishcode264 commented Jul 7, 2024

@nukeop I've submitted a pull request #1626 that addresses the issue where Nuclear doesn't download verified streams. This enhancement allows users to select and download the desired stream directly, improving the download accuracy.

You can view the pull request here Please review and provide any feedback or suggestions.
Thank you!

@nukeop
Copy link
Owner

nukeop commented Jul 7, 2024

I decided to close that PR.

@Krishcode264
Copy link

Krishcode264 commented Jul 7, 2024

@nukeop yeah i see , we have multiple streams for single track , when user changes the stream for perticular track from the play queue and try to download it from there , it doesnt download that newly selected stream but it always download track.streams[0] , how about if we could add the selectedStreamId to track object when selectNewStream() methode calls so that download service would know what perticular stream has to download for that track , thats what i had implemented in that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This thread requests an enhancement to be implemented. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time.
Projects
None yet
Development

No branches or pull requests

4 participants