Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would it be a problem to allow scipy-1.7.0 now , if we have numba-0.53.1 ? #66

Open
stonebig opened this issue Jul 16, 2021 · 8 comments

Comments

@stonebig
Copy link

https://github.com/numba/numba-scipy/blob/master/setup.py#L5

@esc
Copy link
Member

esc commented Jul 16, 2021

#67

@esc
Copy link
Member

esc commented Jul 19, 2021

@stonebig if you can, please do try the branch at #67 if it checks out fine, a release would be possible.

@stonebig
Copy link
Author

it does that on my pypi Windows 10 Python-3.9.6 scipy-0.17.0

C:>pip install --pre  --no-index --trusted-host=None  --find-links=C:\WinP\packages.srcreq -c C:\WinP\constraints.txt   scipy
WARNING: Ignoring invalid distribution -cipy (c:\winp\bd39\bu\wpy64-3960b1\python-3.9.6.amd64\lib\site-packages)
WARNING: Ignoring invalid distribution -cipy (c:\winp\bd39\bu\wpy64-3960b1\python-3.9.6.amd64\lib\site-packages)
Looking in links: c:\WinP\packages.srcreq
Processing c:\winp\packages.srcreq\scipy-1.7.0-cp39-cp39-win_amd64.whl
Requirement already satisfied: numpy<1.23.0,>=1.16.5 in c:\winp\bd39\bu\wpy64-3960b1\python-3.9.6.amd64\lib\site-packages (from scipy) (1.21.0+mkl)
WARNING: Ignoring invalid distribution -cipy (c:\winp\bd39\bu\wpy64-3960b1\python-3.9.6.amd64\lib\site-packages)
Installing collected packages: scipy
WARNING: Ignoring invalid distribution -cipy (c:\winp\bd39\bu\wpy64-3960b1\python-3.9.6.amd64\lib\site-packages)
Successfully installed scipy-1.7.0

C:\WinP\a\numba-scipy-ed96485dbf521a5a7b5a8eebf6f8299b2f71c1df>cd C:\WinP\bd39\bu\WPy64-3960b1\python-3.9.6.amd64\Lib\site-packages\numba_scipy\tests

C:\WinP\bd39\bu\WPy64-3960b1\python-3.9.6.amd64\Lib\site-packages\numba_scipy\tests>python -m pytest
======================================================== test session starts ========================================================
platform win32 -- Python 3.9.6, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: C:\WinP\bd39\bu\WPy64-3960b1\python-3.9.6.amd64\Lib\site-packages\numba_scipy\tests
plugins: anyio-3.2.1, hypothesis-6.14.1, nbval-0.9.6
collected 217 items

test_special.py .....................................................................x........................................ [ 50%]
..............................................x.........x..................................................                    [100%]

========================================================= warnings summary ==========================================================
test_special.py::test_function[voigt_profile-specialization0]
  C:\WinP\bd39\bu\WPy64-3960b1\python-3.9.6.amd64\Lib\site-packages\numba\core\entrypoints.py:22: DeprecationWarning: SelectableGroups dict interface is deprecated. Use select.
    for entry_point in entry_points().get('numba_extensions', []):

test_special.py: 2187 warnings
  C:\WinP\bd39\bu\WPy64-3960b1\python-3.9.6.amd64\Lib\site-packages\numba_scipy\tests\test_special.py:55: DeprecationWarning: non-integer arg n is deprecated, removed in SciPy 1.7.x
    overload_value = numba_func(*arg)

test_special.py: 2187 warnings
  C:\WinP\bd39\bu\WPy64-3960b1\python-3.9.6.amd64\Lib\site-packages\numba_scipy\tests\test_special.py:56: DeprecationWarning: non-integer arg n is deprecated, removed in SciPy 1.7.x
    scipy_value = scipy_func(*arg)

-- Docs: https://docs.pytest.org/en/stable/warnings.html
========================================== 214 passed, 3 xfailed, 4375 warnings in 32.68s ===========================================

C:\WinP\bd39\bu\WPy64-3960b1\python-3.9.6.amd64\Lib\site-packages\numba_scipy\tests>

so apparently as good as your CI

@esc
Copy link
Member

esc commented Jul 19, 2021

@stonebig ok, what about the warnings, should we look into those?

@stonebig
Copy link
Author

stonebig commented Jul 19, 2021

the 4375 DeprecationWarning: non-integer arg n is deprecated, removed in SciPy 1.7.x are of interest to tackle for next cycle, but it can wait next cycle, can't it ? I guess you have it since scipy-1.15.0 ?

scipy/scipy#11045

@esc
Copy link
Member

esc commented Jul 19, 2021

the 4375 DeprecationWarning: non-integer arg n is deprecated, removed in SciPy 1.7.x are of interest to tackle for next cycle, but it can wait next cycle, can't it ? I guess you have it since scipy-1.15.0 ?

scipy/scipy#11045

Yeah, I wasn't quite sure what "removed in 1.7.x" meant and if that includes 1.7.0? -- that kinda seemed to suggest it had already been removed? But then, why would a deprecation warning be issued?

@stonebig
Copy link
Author

Obviously it's not removed as of 1.7.0

@esc
Copy link
Member

esc commented Oct 4, 2021

We are now looking at 1.7.1. in #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants